Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add FAQ entry for non-JS workspaces in the codebase #6612

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Nov 28, 2023

@mehulkar mehulkar requested review from anthonyshew and a team as code owners November 28, 2023 03:58
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation created-by: turborepo owned-by: turborepo labels Nov 28, 2023
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 4:17am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 4:17am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 4:17am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 4:17am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 4:17am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:17am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:17am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:17am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:17am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:17am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:17am

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Nov 28, 2023

🟢 CI successful 🟢

Thanks

@mehulkar mehulkar changed the title docs: add FAQ entry for non-JS workspaces in the codebase feat(docs): add FAQ entry for non-JS workspaces in the codebase Nov 28, 2023
## Can I use Turborepo with a monorepo that non-JS code?

Your monorepo can include subdirectories with any kind of code (a Django app,
Rust crates, Ruby CLIs, etc). Turborepo will largely ignore these directories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a little verbose here. I'd flip this explanation on its head. Instead of saying what it doesn't do, get right into what it does do. Along the lines of "Turbo is built on the conventions of JavaScript meaning you need to fulfill two requirements. Subdirectories need to be workspaces for your JS package manager and have a package manager with the scripts you want to run."

Not going to block because I'm just nitpicking and having something is better than nothing, of course!

@anthonyshew anthonyshew merged commit aae36ba into main Nov 28, 2023
54 checks passed
@anthonyshew anthonyshew deleted the mk/faq branch November 28, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation created-by: turborepo owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants