fix(turbopack): don't parse .ts files as .tsx
#7121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
ForsakenHarmony
force-pushed
the
hrmny/pack-2302-dont-parse-ts-files-as-tsx
branch
from
88b0a69
to
738f5e8
Compare
🟢 CI successful 🟢Thanks |
sokra
reviewed
Jan 26, 2024
| /// Module with TypeScript code with references to imported types | ||
| TypescriptWithTypes, | ||
| TypescriptWithTypes { tsx: bool }, |
There was a problem hiding this comment.
Should we convert WithTypes into a Boolean field too?
There was a problem hiding this comment.
Was wondering if there's a good reason it isn't
ForsakenHarmony
force-pushed
the
hrmny/pack-2302-dont-parse-ts-files-as-tsx
branch
from
738f5e8
to
5b98e9c
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2302-dont-parse-ts-files-as-tsx
branch
from
5b98e9c
to
52a9bca
Compare
ForsakenHarmony
deleted the
hrmny/pack-2302-dont-parse-ts-files-as-tsx
branch
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jan 29, 2024
### What? We currently parse JSX syntax in all typescript files which is wrong. Closes PACK-2302 Turbo PR: vercel/turbo#7121 ### Turbopack Updates * vercel/turbo#7099 <!-- Donny/강동윤 - fix(turbopack): Fix panic from `EcmascriptModuleFacadeModule::content` --> * vercel/turbo#7121 <!-- Leah - fix(turbopack): don't parse `.ts` files as `.tsx` -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently parse JSX syntax in all typescript files which is wrong.
Closes PACK-2302
Next.js PR: vercel/next.js#61219