Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #7412

Closed
wants to merge 4 commits into from
Closed

Update README.md #7412

wants to merge 4 commits into from

Conversation

zsh77
Copy link
Contributor

@zsh77 zsh77 commented Feb 17, 2024

replace acme-core with acme-ui and @acme/ui in multiple cases, as there are no packages named @acme/core but they have changed to @acme/ui in the design system example

Description

Documents of design system example, needed an update as if the files in code was changed and didn't match the package name described in documents. Through this pull request I changed acme-core to acme-ui to fix it. There was another line saying that there is a utils package in the monorepo but in fact there wasn't such package so I removed that line.

Testing Instructions

Changes are only made in README.md

replace acme-core with acme-ui and @acme/ui in multiple cases, as there are no packages named @acme/core but they have changed to @acme/ui in the design system example
@zsh77 zsh77 requested review from anthonyshew and a team as code owners February 17, 2024 13:27
@zsh77 zsh77 requested a review from Zertsov February 17, 2024 13:27
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Feb 17, 2024
Copy link

vercel bot commented Feb 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:50am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 7:50am

Copy link

vercel bot commented Feb 17, 2024

@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@ijjk
Copy link
Member

ijjk commented Feb 20, 2024

Allow CI Workflow Run

  • approve CI run for commit: 7d6acad

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@anthonyshew anthonyshew enabled auto-merge (squash) February 20, 2024 03:34
@zsh77
Copy link
Contributor Author

zsh77 commented Apr 7, 2024

closing this old PR in favor of #7885

@zsh77 zsh77 closed this Apr 7, 2024
auto-merge was automatically disabled April 7, 2024 12:57

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants