feat(turbopack): Enable lightningcss for turbopack by default #7524

kdy1 · 2024-02-27T03:42:13Z

Description

Enable lightningcss by default, for --turbo mode.

Testing Instructions

next.js counterpart: vercel/next.js#62565

vercel · 2024-02-27T03:42:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-native-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2024 0:21am
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2024 0:21am
rust-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2024 0:21am
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2024 0:21am

7 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2024 0:21am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2024 0:21am
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2024 0:21am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2024 0:21am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2024 0:21am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2024 0:21am
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2024 0:21am

github-actions · 2024-02-27T03:44:05Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions · 2024-02-27T03:45:08Z

⚠️ This change may fail to build next-swc.

Logs

error: failed to select a version for `turbopack-binding`.
    ... required by package `next-core v0.1.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/next-core)`
    ... which satisfies path dependency `next-core` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `*` (locked to 0.1.0) are: 0.1.0

the package `next-core` depends on `turbopack-binding`, with features: `__turbopack_build` but `turbopack-binding` does not have these features.


failed to select a version for `turbopack-binding` which could resolve this conflict

See job summary for details

github-actions · 2024-02-27T03:48:40Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

crates/turbopack-css/src/asset.rs

sokra · 2024-02-28T08:22:28Z

...s/output/crates_turbopack-tests_tests_snapshot_css_chained-attributes_input_7c9d25._.css.map

-    {"offset": {"line": 28, "column": 1}, "map": {"version":3,"sources":[],"names":[],"mappings":"A"}},
-    {"offset": {"line": 34, "column": 0}, "map": {"version":3,"sources":["/turbopack/[project]/crates/turbopack-tests/tests/snapshot/css/chained-attributes/input/style.css"],"sourcesContent":["@import url(\"./a.css\") layer(layer) supports(not(display: inline-grid)) print;\n\n.style {\n  color: yellow;\n}\n"],"names":[],"mappings":"AAEA,CAAC,KAAK,CAAC,CAAC;EACN,KAAK,EAAE,MAAM;AACf,CAAC"}},
-    {"offset": {"line": 36, "column": 1}, "map": {"version":3,"sources":[],"names":[],"mappings":"A"}}]
+    {"offset": {"line": 4, "column": 0}, "map": {"version":3,"sources":["[project]/crates/turbopack-tests/tests/snapshot/css/chained-attributes/input/c.css"],"names":[],"mappings":"A"}},


sourcesContent is missing in SourceMaps and the mappings are empty?

I tried debugging with dbg, but it seems like the source map produced by lightningcss is relatively minimal at the first place.

cc @devongovett Can you take a look?

For sourcesContent, you need to call source_map.set_source_content for each source index to add it. Lightning CSS doesn't store a reference or copy to the original code so that's up to you. I see here where you add the source files but I couldn't find where the source content gets set so maybe that's missing? Or you could get the content some other way here.

As for the mappings themselves, I'm not sure without debugging it myself, but I see a couple possibilities:

Maybe try adding the sources before calling to_css instead of after?

When converting the source map to your internal format, maybe check that the source index is passed through (right now it is always None). Looks like maybe you can use add_raw instead. Not sure if that is related. At least verify that there are mappings there.

turbo/crates/turbopack-css/src/process.rs

Lines 837 to 844 in b61c98e

builder.add(

m.generated_line,

m.generated_column,

m.original.map(|v| v.original_line).unwrap_or_default(),

m.original.map(|v| v.original_column).unwrap_or_default(),

None,

None,

);

The mappings are probably more sparse than you might expect though. Basically there's one per rule since that's the level of granularity that browser dev tools operate at, so more is unnecessary. But it shouldn't be empty at least.

...g/output/crates_turbopack-tests_tests_snapshot_css_css-legacy-nesting_input_style_7d7e1c.css

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

# Turbopack * vercel/turbo#7682  * vercel/turbo#7524  ### What? Enable lightningcss by default, for `--turbo` mode. ### Why? It's time to do it 😄 ### How? Turbopack counterpart: vercel/turbo#7524 Closes PACK-2600

JesseKoldewijn · 2024-03-20T21:38:59Z

❤️

kdy1 self-assigned this Feb 27, 2024

turbo-orchestrator bot added created-by: turbopack owned-by: turbopack labels Feb 27, 2024

kdy1 mentioned this pull request Feb 27, 2024

feat(turbopack): Enable lightningcss for turbopack by default vercel/next.js#62565

Merged

vercel bot deployed to Preview – rust-docs February 27, 2024 03:48 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 27, 2024 04:15 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 27, 2024 04:16 View deployment

vercel bot deployed to Preview – rust-docs February 27, 2024 04:33 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 27, 2024 14:46 View deployment

vercel bot deployed to Preview – rust-docs February 27, 2024 14:55 View deployment

kdy1 force-pushed the kdy1/lcss-on branch from 27322c8 to 765df83 Compare February 28, 2024 03:24

vercel bot deployed to Preview – examples-nonmonorepo February 28, 2024 03:25 View deployment

vercel bot deployed to Preview – rust-docs February 28, 2024 03:34 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 28, 2024 03:50 View deployment

vercel bot deployed to Preview – rust-docs February 28, 2024 03:58 View deployment

kdy1 force-pushed the kdy1/lcss-on branch from ddcfb14 to 3db5be6 Compare February 28, 2024 07:06

vercel bot deployed to Preview – examples-nonmonorepo February 28, 2024 07:07 View deployment

vercel bot deployed to Preview – rust-docs February 28, 2024 07:15 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 28, 2024 08:03 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 28, 2024 08:06 View deployment

kdy1 marked this pull request as ready for review February 28, 2024 08:17

kdy1 requested a review from a team as a code owner February 28, 2024 08:17

sokra reviewed Feb 28, 2024

View reviewed changes

crates/turbopack-css/src/asset.rs Outdated Show resolved Hide resolved

vercel bot deployed to Preview – rust-docs February 28, 2024 08:21 View deployment

sokra reviewed Feb 28, 2024

View reviewed changes

...g/output/crates_turbopack-tests_tests_snapshot_css_css-legacy-nesting_input_style_7d7e1c.css Outdated Show resolved Hide resolved

vercel bot deployed to Preview – examples-nonmonorepo March 8, 2024 00:02 View deployment

vercel bot deployed to Preview – turbo-site March 8, 2024 00:03 View deployment

kdy1 and others added 20 commits March 8, 2024 09:06

Rename

661cd69

Drop imports

840506d

Update test refs

4a37ffa

Update test refs

d3b8410

Do not recover from some kind of errors

fb538b9

eof

880afe7

Update test refs

3f11f07

Update crates/turbopack-css/src/asset.rs

9d30b13

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

use_swc_css

1d5b465

swc_css

75e1520

pattern

6006974

No minify

4ea2c68

Update test snapshots

c4f6619

Rename

f12da02

Use add_raw

d78258e

sources content

ae87ff0

clippy

2296d1c

Update test snapshot

a032b90

Reduce clone

e88f5d0

fix clippy

489bc85

kdy1 force-pushed the kdy1/lcss-on branch from 0528374 to 489bc85 Compare March 8, 2024 00:06

vercel bot deployed to Preview – examples-nonmonorepo March 8, 2024 00:07 View deployment

vercel bot deployed to Preview – turbo-site March 8, 2024 00:07 View deployment

vercel bot deployed to Preview – rust-docs March 8, 2024 00:21 View deployment

kdy1 merged commit 7d7eeec into main Mar 11, 2024
48 of 51 checks passed

kdy1 deleted the kdy1/lcss-on branch March 11, 2024 02:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(turbopack): Enable lightningcss for turbopack by default #7524

feat(turbopack): Enable lightningcss for turbopack by default #7524

kdy1 commented Feb 27, 2024 •

edited by padmaia

vercel bot commented Feb 27, 2024 •

edited

github-actions bot commented Feb 27, 2024 •

edited

github-actions bot commented Feb 27, 2024 •

edited

github-actions bot commented Feb 27, 2024 •

edited

sokra Feb 28, 2024 •

edited

kdy1 Mar 4, 2024

devongovett Mar 4, 2024

JesseKoldewijn commented Mar 20, 2024

	builder.add(
	m.generated_line,
	m.generated_column,
	m.original.map(\|v\| v.original_line).unwrap_or_default(),
	m.original.map(\|v\| v.original_column).unwrap_or_default(),
	None,
	None,
	);

feat(turbopack): Enable lightningcss for turbopack by default #7524

feat(turbopack): Enable lightningcss for turbopack by default #7524

Conversation

kdy1 commented Feb 27, 2024 • edited by padmaia

Description

Testing Instructions

vercel bot commented Feb 27, 2024 • edited

github-actions bot commented Feb 27, 2024 • edited

🟢 Turbopack Benchmark CI successful 🟢

github-actions bot commented Feb 27, 2024 • edited

github-actions bot commented Feb 27, 2024 • edited

⚠️ CI failed ⚠️

sokra Feb 28, 2024 • edited

Choose a reason for hiding this comment

kdy1 Mar 4, 2024

Choose a reason for hiding this comment

devongovett Mar 4, 2024

Choose a reason for hiding this comment

JesseKoldewijn commented Mar 20, 2024

kdy1 commented Feb 27, 2024 •

edited by padmaia

vercel bot commented Feb 27, 2024 •

edited

github-actions bot commented Feb 27, 2024 •

edited

github-actions bot commented Feb 27, 2024 •

edited

github-actions bot commented Feb 27, 2024 •

edited

sokra Feb 28, 2024 •

edited