feat(turborepo): Watch mode #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
ccfb9c7
to
fb91bd6
Compare
NicholasLYang
force-pushed
the
nicholasyang/package-watching
branch
from
4183911
to
d576090
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
fb91bd6
to
8ede959
Compare
NicholasLYang
force-pushed
the
nicholasyang/package-watching
branch
from
814a01c
to
f039634
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
8ede959
to
420f2b7
Compare
NicholasLYang
force-pushed
the
nicholasyang/package-watching
branch
from
f039634
to
4f05e8e
Compare
Instead of using `--filter` in our re-running of tasks for watch mode, we instead prune the task graph to run the changed task and its dependent tasks. This has the benefit of following the task graph and not the package graph. You can verify this works by creating a task dependency relation that is not in the package graph. So, make a `ui#test` task that depends on a `docs#test` task, but don't have `ui` depend on `docs`. Then verify that when the `docs` are changed, we re-run the `ui#test` task too. Closes TURBO-2752
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
527ad4f
to
4711a79
Compare
gsoltis
approved these changes
Apr 19, 2024
|
How do we use it? :) |
chris-olszewski
added a commit
that referenced
this pull request
Apr 24, 2024
### Description I messed up a resolving a merge conflict and didn't migrate some args that moved from `ExecutionArgs` to `RunArgs` in #7613 ### Testing Instructions Tests on CI pass Closes TURBO-2872
chris-olszewski
added a commit
that referenced
this pull request
Apr 30, 2024
### Description I messed up a resolving a merge conflict and didn't migrate some args that moved from `ExecutionArgs` to `RunArgs` in #7613 ### Testing Instructions Tests on CI pass Closes TURBO-2872
chris-olszewski
added a commit
that referenced
this pull request
May 10, 2024
### Description I messed up a resolving a merge conflict and didn't migrate some args that moved from `ExecutionArgs` to `RunArgs` in #7613 ### Testing Instructions Tests on CI pass Closes TURBO-2872
chris-olszewski
added a commit
that referenced
this pull request
May 14, 2024
### Description I messed up a resolving a merge conflict and didn't migrate some args that moved from `ExecutionArgs` to `RunArgs` in #7613 ### Testing Instructions Tests on CI pass Closes TURBO-2872
This was referenced May 18, 2024
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2024
### Description I messed up a resolving a merge conflict and didn't migrate some args that moved from `ExecutionArgs` to `RunArgs` in #7613 ### Testing Instructions Tests on CI pass Closes TURBO-2872
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description I messed up a resolving a merge conflict and didn't migrate some args that moved from `ExecutionArgs` to `RunArgs` in #7613 ### Testing Instructions Tests on CI pass Closes TURBO-2872
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements an MVP version of watch mode that takes the package changes stream and re-runs package tasks as needed.
Testing Instructions
Closes TURBO-2519