feat: add mechanism to bypass turbo engine for annotated methods #7675

arlyon · 2024-03-08T08:12:00Z

Description

Testing Instructions

vercel · 2024-03-08T08:12:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 11:10am
rust-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 11:10am
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 11:10am

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	May 16, 2024 11:10am

arlyon · 2024-03-08T08:12:14Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

feat: add mechanism to bypass turbo engine for annotated methods #7675 👈
[turbo trace] add ability to filter by value and occurences #7674 : 1 other dependent PR (#8037 )
[turbo-trace] add additional filter modes for allocs over time #7673
fix rustc bug in turbopack-trace-server #8158
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arlyon and the rest of your teammates on Graphite

github-actions · 2024-03-08T08:14:00Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions · 2024-03-08T08:14:54Z

✅ This change can build next-swc

github-actions · 2024-03-08T08:18:16Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust clippy
Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

sokra · 2024-03-08T14:43:54Z

crates/turbo-tasks-build/src/lib.rs

+        if has_attribute(&fn_item.attrs, "function")
+            && !ignored::task_ignored(&fn_item.sig.ident.to_string())


A problem is probably that just ignoring the attribute is not enough. The attribute is also changing the signature, e. g. async fn X() -> Result<Vc<Y>> becomes fn X() -> Vc<Y>.

Yeah I am going to see if it is possible to rewrite the signatures as well, have been messing around with it today to see if we can do that without requiring upstream tasks to change

This PR still needs some work, since we will need to transparently forward VCs or eagerly evaluate them. We need to ensure that the parent task is still lazy, but that we are just cutting out task tracking between tasks.

turbo-orchestrator bot added created-by: turborepo owned-by: turbopack labels Mar 8, 2024

This was referenced Mar 8, 2024

[turbo-trace] add additional filter modes for allocs over time #7673

Merged

[turbo trace] add ability to filter by value and occurences #7674

Open

vercel bot deployed to Preview – examples-nonmonorepo March 8, 2024 08:12 View deployment

vercel bot deployed to Preview – turbo-site March 8, 2024 08:13 View deployment

vercel bot deployed to Preview – rust-docs March 8, 2024 08:21 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 46b7cf3 to aa14884 Compare March 8, 2024 09:01

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 92ad696 to de937a1 Compare March 8, 2024 09:01

vercel bot deployed to Preview – examples-nonmonorepo March 8, 2024 09:01 View deployment

vercel bot deployed to Preview – turbo-site March 8, 2024 09:02 View deployment

vercel bot deployed to Preview – rust-docs March 8, 2024 09:10 View deployment

sokra reviewed Mar 8, 2024

View reviewed changes

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from aa14884 to 9241414 Compare March 19, 2024 14:50

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from de937a1 to 4615e87 Compare March 19, 2024 14:50

vercel bot deployed to Preview – examples-nonmonorepo March 19, 2024 14:51 View deployment

vercel bot deployed to Preview – rust-docs March 19, 2024 15:00 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9241414 to 9b6e234 Compare March 19, 2024 16:07

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 4615e87 to abe08f2 Compare March 19, 2024 16:07

vercel bot deployed to Preview – examples-nonmonorepo March 19, 2024 16:08 View deployment

vercel bot deployed to Preview – rust-docs March 19, 2024 16:17 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9b6e234 to 9139a05 Compare March 19, 2024 16:32

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from abe08f2 to 8224476 Compare March 19, 2024 16:32

vercel bot deployed to Preview – examples-nonmonorepo March 19, 2024 16:33 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 9139a05 to c9e26bc Compare March 19, 2024 16:37

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from f53a525 to 9f50dd4 Compare April 24, 2024 19:11

This was referenced Apr 24, 2024

create turbo-static for compile time graph analysis #8037

Open

add tags to turbo tasks #8038

Open

vercel bot deployed to Preview – examples-nonmonorepo April 24, 2024 19:11 View deployment

vercel bot deployed to Preview – rust-docs April 24, 2024 19:21 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 51a0259 to 01f812c Compare May 15, 2024 11:25

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 9f50dd4 to d49e885 Compare May 15, 2024 11:25

vercel bot deployed to Preview – examples-nonmonorepo May 15, 2024 11:25 View deployment

vercel bot deployed to Preview – rust-docs May 15, 2024 11:35 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 01f812c to 08ad50d Compare May 15, 2024 15:25

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from d49e885 to fbab81c Compare May 15, 2024 15:25

vercel bot deployed to Preview – examples-nonmonorepo May 15, 2024 15:25 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 08ad50d to ed4bedc Compare May 15, 2024 15:27

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from fbab81c to 739c4e3 Compare May 15, 2024 15:27

vercel bot deployed to Preview – examples-nonmonorepo May 15, 2024 15:27 View deployment

vercel bot deployed to Preview – rust-docs May 15, 2024 15:46 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from ed4bedc to 7a20d4d Compare May 16, 2024 08:06

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 739c4e3 to 2671771 Compare May 16, 2024 08:06

arlyon mentioned this pull request May 16, 2024

fix rustc bug in turbopack-trace-server #8158

Merged

vercel bot deployed to Preview – examples-nonmonorepo May 16, 2024 08:06 View deployment

vercel bot deployed to Preview – rust-docs May 16, 2024 08:16 View deployment

arlyon added 4 commits May 16, 2024 12:59

fix rustc bug in turbopack-trace-server

b17a90e

add additional filter modes for allocation and alloc count over time

4c292ac

add ability to filter by value and occurences

07e95b9

feat: add mechanism to bypass turbo engine for annotated methods

3fb2eb1

This PR still needs some work, since we will need to transparently forward VCs or eagerly evaluate them. We need to ensure that the parent task is still lazy, but that we are just cutting out task tracking between tasks.

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 7a20d4d to 07e95b9 Compare May 16, 2024 11:00

arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 2671771 to 3fb2eb1 Compare May 16, 2024 11:00

vercel bot deployed to Preview – examples-nonmonorepo May 16, 2024 11:01 View deployment

vercel bot deployed to Preview – rust-docs May 16, 2024 11:10 View deployment

arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 07e95b9 to 003b9b0 Compare May 22, 2024 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add mechanism to bypass turbo engine for annotated methods #7675

feat: add mechanism to bypass turbo engine for annotated methods #7675

arlyon commented Mar 8, 2024 •

edited by padmaia

vercel bot commented Mar 8, 2024 •

edited

arlyon commented Mar 8, 2024 •

edited

github-actions bot commented Mar 8, 2024 •

edited

github-actions bot commented Mar 8, 2024 •

edited

github-actions bot commented Mar 8, 2024 •

edited

sokra Mar 8, 2024

arlyon Mar 8, 2024

		if has_attribute(&fn_item.attrs, "function")
		&& !ignored::task_ignored(&fn_item.sig.ident.to_string())

feat: add mechanism to bypass turbo engine for annotated methods #7675

Are you sure you want to change the base?

feat: add mechanism to bypass turbo engine for annotated methods #7675

Conversation

arlyon commented Mar 8, 2024 • edited by padmaia

Description

Testing Instructions

vercel bot commented Mar 8, 2024 • edited

arlyon commented Mar 8, 2024 • edited

github-actions bot commented Mar 8, 2024 • edited

🟢 Turbopack Benchmark CI successful 🟢

github-actions bot commented Mar 8, 2024 • edited

github-actions bot commented Mar 8, 2024 • edited

⚠️ CI failed ⚠️

sokra Mar 8, 2024

Choose a reason for hiding this comment

arlyon Mar 8, 2024

Choose a reason for hiding this comment

arlyon commented Mar 8, 2024 •

edited by padmaia

vercel bot commented Mar 8, 2024 •

edited

arlyon commented Mar 8, 2024 •

edited

github-actions bot commented Mar 8, 2024 •

edited

github-actions bot commented Mar 8, 2024 •

edited

github-actions bot commented Mar 8, 2024 •

edited