fix: add extra detail to summary showing items from remote cache #7697
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
arlyon
commented
Mar 12, 2024
| @@ -159,14 +168,23 @@ impl<'a> ExecutionSummary<'a> { | |||
| fn successful(&self) -> usize { | |||
| self.success + self.cached | |||
| } | |||
|
|
|||
| fn add_cached(&mut self, source: CacheSource) { | |||
| self.cached += 1; | |||
There was a problem hiding this comment.
To preserve run summary output we just add a new field for remote rather than splitting into two. Naturally cached - cached_remote = cached_local if we need it one day.
chris-olszewski
approved these changes
Mar 12, 2024
| @@ -159,14 +168,23 @@ impl<'a> ExecutionSummary<'a> { | |||
| fn successful(&self) -> usize { | |||
| self.success + self.cached | |||
| } | |||
|
|
|||
| fn add_cached(&mut self, source: CacheSource) { | |||
There was a problem hiding this comment.
I don't see this used anywhere so I think it can get removed? In general I think we don't want to be changing the counts on the ExecutionSummary and have all modifications happen to SummaryState
| @@ -82,6 +86,12 @@ impl<'a> ExecutionSummary<'a> { | |||
| String::new() | |||
| }; | |||
|
|
|||
| let cache_line = if self.cached_remote > 0 { | |||
| format!("{} (of which {} remote)", self.cached, self.cached_remote) | |||
There was a problem hiding this comment.
Don't want to bikeshed this a ton, but I feel like we can simplify this to just 10 (8 remote) or 10 (2 local, 8 remote).
mehulkar
reviewed
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A quick fix that closes #2129
It adds a small additional UI when tasks are loaded from the remote
cache. Tasks that were not fetched from cache do not have the extra
annotation and retain the original formatting.
Testing Instructions
Run a build with remote cache set up:
Tasks: 0 successful, 2 total
Cached: 2 (of which 2 remote) cached, 2 total
Time: 1.141s
Run another build:
Tasks: 0 successful, 2 total
Cached: 2 cached, 2 total
Time: 1.141s
Closes TURBO-2590