New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(turbopack): Use correct method for the proxy of fetch
#7739
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this but it still didn't pass the test in next.js - did you able to make it actually work?
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
🟢 CI successful 🟢Thanks |
Actually nope, I think it's a bug of |
It works if I add let url = url.replace("https://", "http://"); so I think |
That's what I saw as well (https://vercel.slack.com/archives/C03EWR7LGEN/p1707871876798169?thread_ts=1707788191.248449&cid=C03EWR7LGEN) |
Description
We should use
Proxy::all
instead ofProxy::http
orProxy::https
.Closes PACK-2448
Testing Instructions
See next.js counterpart: vercel/next.js#63309