Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turbopack): Use correct method for the proxy of fetch #7739

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 15, 2024

Description

We should use Proxy::all instead of Proxy::http or Proxy::https.

Closes PACK-2448

Testing Instructions

See next.js counterpart: vercel/next.js#63309

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 6:01am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 6:01am
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 6:01am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 6:01am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 6:01am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 6:01am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 6:01am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 6:01am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 6:01am
rust-docs ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 6:01am

Copy link
Contributor

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this but it still didn't pass the test in next.js - did you able to make it actually work?

Copy link
Contributor

github-actions bot commented Mar 15, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Mar 15, 2024

🟢 CI successful 🟢

Thanks

@kdy1
Copy link
Member Author

kdy1 commented Mar 15, 2024

Actually nope, I think it's a bug of reqwest. It does not work as documented.

@kdy1 kdy1 marked this pull request as draft March 15, 2024 06:21
@kdy1
Copy link
Member Author

kdy1 commented Mar 15, 2024

It works if I add

let url = url.replace("https://", "http://");

so I think reqwest is not sending https requests to the proxy, regardless of the method.

@kwonoj
Copy link
Contributor

kwonoj commented Mar 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants