Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): dependencies filter should match transitive deps #7886

Merged
merged 1 commit into from Apr 2, 2024

Conversation

chris-olszewski
Copy link
Contributor

@chris-olszewski chris-olszewski commented Apr 2, 2024

Description

Fixes bug from port where ... filter would only select immediate dependencies.

In Go we used graph.Ancestors which performs a full DFS, not just immediate ancestors. This PR updates so we do the same in Rust.

Testing Instructions

Added unit test that uses ... filter on a project with transitive dependencies.

We already have test cases for the reverse case of including reverse dependants

For good measure did a manual check in repo with following dep chain: docs -> @repo/ui -> foo

[0 olszewski@chriss-mbp] /tmp/foo $ turbo_dev --skip-infer build --filter=docs... --output-logs=errors-only --no-daemon     
• Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, foo
• Running build in 5 packages
• Remote caching disabled

 Tasks:    2 successful, 2 total
Cached:    2 cached, 2 total
  Time:    149ms >>> FULL TURBO

[0 olszewski@chriss-mbp] /tmp/foo $ turbo_dev --skip-infer build --filter=...foo --output-logs=errors-only --no-daemon  
• Packages in scope: @repo/ui, docs, foo, web
• Running build in 4 packages
• Remote caching disabled

 Tasks:    3 successful, 3 total
Cached:    2 cached, 3 total
  Time:    9.829s 

Closes TURBO-2749

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 2, 2024 5:23pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 5:23pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm
examples-native-web ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 2, 2024 5:23pm

Copy link
Contributor

github-actions bot commented Apr 2, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@chris-olszewski chris-olszewski enabled auto-merge (squash) April 2, 2024 17:30
Copy link
Contributor

github-actions bot commented Apr 2, 2024

🟢 CI successful 🟢

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants