Respect output mode 'none' even when caching is disabled #7900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suppose I have some pipline like this:
The
outputMode
is ignored because ofcache
being false. That's annoying. I don't want to see myrm -rf
running every time I do I build, including builds where all the rest of the tasks are cached (I tend to usenew-only
for most other tasks).Testing Instructions
I am not a Rust programmer but I think I have found the place that would need to be changed. To test the change, just create any simple package.son task that generates output (
"echo": "echo \"hello world\"",
) and run it from a TurboRepo task with caching false and outMode none, as above.PS
errors-only
PS having absolutely no output would be okay. Even better would be an implementation of errors-only, outputting one line saying that the task has been executed because it is set not to cache, and that it executed successfully. I think that would involve something like the below code (copied from about line 195 of the same file I've modified in this PR), but again, I don't know Rust or your codebase: