Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in dev script of a kitchen-sink's package #7913

Merged
merged 1 commit into from Apr 8, 2024

Conversation

zsh77
Copy link
Contributor

@zsh77 zsh77 commented Apr 8, 2024

Description

Fixed the problem of @repo/logger not watching for changes. I think a part of this issue would also be fixed #7871.

Testing Instructions

After running the dev script of the monorepo, making changes in logger package and saving it should result in building the logger package once more.

@zsh77 zsh77 requested review from anthonyshew and a team as code owners April 8, 2024 14:14
@zsh77 zsh77 requested a review from tknickman April 8, 2024 14:14
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Apr 8, 2024
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:15pm
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:15pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:15pm
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:15pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 2:15pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 2:15pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 2:15pm

Copy link

vercel bot commented Apr 8, 2024

@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Apr 8, 2024

Allow CI Workflow Run

  • approve CI run for commit: 3fbba24

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add example that supports HMR for backend API project
3 participants