Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storybook docs #7954

Merged
merged 8 commits into from Apr 22, 2024
Merged

Update storybook docs #7954

merged 8 commits into from Apr 22, 2024

Conversation

zsh77
Copy link
Contributor

@zsh77 zsh77 commented Apr 14, 2024

Description

  • fixed the init script of storybook on the npm tab, (the exact changes we had in the PR: change init script of storybook #7695 using npm instead of pnpm)
  • replaced ui with @repo/ui
  • bug fix of importing a button from an undefined export specifier

Testing Instructions

Going through with the process of adding storybook to turborepo should work fine which is:

  • cd apps
  • npm create vite
  • cd workshop
  • npx sb init

@zsh77 zsh77 requested review from anthonyshew and a team as code owners April 14, 2024 07:56
@zsh77 zsh77 requested a review from tknickman April 14, 2024 07:56
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation owned-by: turborepo labels Apr 14, 2024
Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:44pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:44pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:44pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:44pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:44pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:44pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 3:44pm
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Apr 22, 2024 3:44pm

Copy link

vercel bot commented Apr 14, 2024

@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Apr 14, 2024

Allow CI Workflow Run

  • approve CI run for commit: cf626c4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants