Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(commands/prune.rs): Add More detail in MissingWorkspace error #7956

Merged

Conversation

WillKirkmanM
Copy link
Contributor

Description

Related to #7948, in running the turbo prune when specifying a package name, it is assumed that the package name is the name of the folder in apps/web or packages/eslint-config. The real case is that the package name is the name found in the package.json file in the apps/* directory.

This pull requests adds more detail and clarity towards the uncertainty of defining what the package means.

Files Edited
Line 46 of https://github.com/vercel/turbo/blob/main/crates/turborepo-lib/src/commands/prune.rs

    #[error("invalid scope: package {0} not found")]
    MissingWorkspace(PackageName),

to

    #[error("invalid scope: package with name {0} in package.json not found")]
    MissingWorkspace(PackageName),

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 4:22pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 4:22pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 4:22pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:22pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:22pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:22pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:22pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:22pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:22pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:22pm

Copy link

vercel bot commented Apr 15, 2024

@WillKirkmanM is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@WillKirkmanM WillKirkmanM changed the title Fix(commands/prune.rs): More detail in MissingWorkspace error Fix(commands/prune.rs): Add More detail in MissingWorkspace error Apr 15, 2024
@ijjk
Copy link
Member

ijjk commented Apr 15, 2024

Allow CI Workflow Run

  • approve CI run for commit: 76decae

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants