Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin eslint version #7971

Merged
merged 1 commit into from Apr 15, 2024
Merged

chore: pin eslint version #7971

merged 1 commit into from Apr 15, 2024

Conversation

chris-olszewski
Copy link
Contributor

@chris-olszewski chris-olszewski commented Apr 15, 2024

Description

eslint 9.0.0 has some breaking changes that our current fixture isn't set up to support. This is preventing us from releasing new versions of turbo.

Future work is to update the fixture to work with eslint 9

Testing Instructions

turbo test --filter=eslint-plugin-turbo now passes

Closes TURBO-2808

@chris-olszewski chris-olszewski marked this pull request as ready for review April 15, 2024 19:23
@chris-olszewski chris-olszewski requested a review from a team as a code owner April 15, 2024 19:23
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 15, 2024 7:23pm
9 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
examples-native-web ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm
rust-docs ⬜️ Ignored (Inspect) Apr 15, 2024 7:23pm

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 15, 2024

🟢 CI successful 🟢

Thanks

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint@8.57.0 environment, filesystem Transitive: eval, shell, unsafe +98 10.7 MB eslintbot

🚮 Removed packages: npm/eslint@9.0.0

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: turborepo owned-by: turborepo pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants