chore: differentiate rust changes from building turbo #8001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
mehulkar
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
FWIW, I think it would make sense to exclude the turborepo-repository tests as a check before release, since it is independently released. We do this in CI also:
turbo/.github/workflows/test.yml
Line 395 in e63b1a8
and turborepo-repository is independently tested in its own workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new dummy task that will be invalidated whenever turborepo related Rust code changes.
I noticed we were building the
turbobinary when running our JS tests. This is due toturborepo-repositorydepending oncli#build, but I believe that we really just want it invalidate on any Rust code changes.Testing Instructions
Verify that updating a Rust file causes a cache miss for both
turbo build --filter=cliandturbo build --filter=turborepo-repository.Closes TURBO-2837