Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add carraige return after cache log messages #8015

Merged
merged 3 commits into from Apr 30, 2024
Merged

fix(ui): add carraige return after cache log messages #8015

merged 3 commits into from Apr 30, 2024
+149 −84

Conversation

chris-olszewski
Copy link
Contributor

@chris-olszewski chris-olszewski commented Apr 22, 2024 •
edited by padmaia

Description

Forgot that we need to bring our own \r in raw mode as \n will only move the cursor down and not back to the home column.

Testing Instructions

Before
Screenshot 2024-04-22 at 8 55 45 AM

After
Screenshot 2024-04-22 at 8 53 34 AM

Closes TURBO-2855

@chris-olszewski chris-olszewski marked this pull request as ready for review April 22, 2024 15:57
@chris-olszewski chris-olszewski requested a review from a team as a code owner April 22, 2024 15:57
@vercel Vercel
Copy link

vercel bot commented Apr 22, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 4:34pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited

🟢 CI successful 🟢

Thanks

@chris-olszewski chris-olszewski merged commit a82c8d3 into main Apr 30, 2024
56 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_ui_add_cr branch April 30, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@gsoltis gsoltis Awaiting requested review from gsoltis gsoltis is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
created-by: turborepo owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-olszewski @NicholasLYang