Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix clippy error and add generic CI check #8040

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Apr 24, 2024

Description

Keep getting errors from clippy locally, added a non required job as a sanity check

Closes PACK-3001

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 10:31pm
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 10:31pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 10:31pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 10:31pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 10:31pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 10:31pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 10:31pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 10:31pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 10:31pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 10:31pm

Copy link
Contributor

github-actions bot commented Apr 24, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Apr 24, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like to wait on this until after #8027 is merged (if turbopack team can be convinced of it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants