add some more logging to the extension startup #8047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
arlyon
force-pushed
the
arlyon/lsp-logging
branch
from
c0b55ad
to
c77e4b0
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
gsoltis
approved these changes
Apr 26, 2024
arlyon
force-pushed
the
arlyon/lsp-logging
branch
from
c77e4b0
to
b05f1e1
Compare
arlyon
force-pushed
the
arlyon/lsp-logging
branch
from
b05f1e1
to
3b9f880
Compare
|
✅ This change can build |
arlyon
force-pushed
the
arlyon/lsp-logging
branch
from
3b9f880
to
e18bf4c
Compare
arlyon
force-pushed
the
arlyon/lsp-logging
branch
from
e18bf4c
to
f8508e5
Compare
arlyon
force-pushed
the
arlyon/lsp-logging
branch
from
f8508e5
to
3af4bfb
Compare
arlyon
force-pushed
the
arlyon/lsp-logging
branch
from
3af4bfb
to
9916337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a logging channel for the turbo vsc extension and rework some logging to prevent noisiness in the notification bar. This also adds some extra handling for homebrew based npm installs, and some additional handling to ensure paths are trimmed properly.
Testing Instructions
Build and boot up the extension and observe the new output tab for Turbo.
Closes TURBO-2894