Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Turborepo): Be explicit about which binary we failed to find #8050

Merged
merged 1 commit into from Apr 29, 2024

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Apr 26, 2024

Description

  • change Error::Which to not be transparent, and to display the binary we tried to find
  • update the calls to which("bun") and which("yarn") to use the new pattern.

Testing Instructions

Existing test suite

Closes TURBO-2900

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 10:04pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 10:04pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 10:04pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:04pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:04pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:04pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:04pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:04pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:04pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:04pm

Copy link
Contributor

github-actions bot commented Apr 26, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 26, 2024

🟢 CI successful 🟢

Thanks

@gsoltis gsoltis merged commit f1bf03f into main Apr 29, 2024
56 checks passed
@gsoltis gsoltis deleted the gsoltis/explicit_which_error branch April 29, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants