Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Turborepo): Fix as_inputs to include ! #8119

Merged
merged 3 commits into from May 9, 2024
Merged

fix(Turborepo): Fix as_inputs to include ! #8119

merged 3 commits into from May 9, 2024

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented May 9, 2024

Description

  • GlobSet::as_inputs now prefixes exclusions with ! so they are properly parsed

Testing Instructions

Added new hash watching test with exclusions in the inputs.

Fixes #8112

@gsoltis gsoltis requested a review from a team as a code owner May 9, 2024 17:03
@gsoltis gsoltis requested review from tknickman and paulogdm May 9, 2024 17:03
@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:28pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:28pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:28pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 7:28pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 7:28pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 7:28pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 7:28pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 7:28pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 7:28pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 7:28pm

@gsoltis gsoltis requested review from chris-olszewski and NicholasLYang and removed request for tknickman and paulogdm May 9, 2024 17:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

NicholasLYang
NicholasLYang approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@NicholasLYang NicholasLYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions but no blockers

crates/turborepo-filewatch/src/globwatcher.rs Show resolved Hide resolved
crates/turborepo-filewatch/src/hash_watcher.rs Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited

🟢 CI successful 🟢

Thanks

@gsoltis gsoltis enabled auto-merge (squash) May 9, 2024 19:09
@gsoltis gsoltis merged commit be6c39f into main May 9, 2024
56 checks passed
@gsoltis gsoltis deleted the gsoltis/fix_negative_inputs branch May 9, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski

Assignees
No one assigned
Labels
created-by: turborepo owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inputs including invalid files per wildcard
2 participants
@gsoltis @NicholasLYang