Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fs cache location. #8126

Merged
merged 6 commits into from May 17, 2024
Merged

Move fs cache location. #8126

merged 6 commits into from May 17, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented May 10, 2024

Description

Moves the file system cache to .turbo as discussed in #842.

Testing Instructions

Find your favorite Turborepo of choice and run a turbo command twice. You should miss cache on the first run and hit cache on the second.

CLOSES TURBO-3130

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 4:23am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am
rust-docs ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 4:23am

Copy link
Contributor

github-actions bot commented May 10, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@anthonyshew anthonyshew changed the base branch from main to turborepo_2 May 10, 2024 19:27
@anthonyshew anthonyshew requested a review from a team as a code owner May 10, 2024 19:27
@turbo-orchestrator turbo-orchestrator bot added area: ci area: docs Improvements or additions to documentation owned-by: turbopack pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-gen pkg: turbo-ignore packages/turbo-ignore pkg: turbo-workspaces labels May 10, 2024
Copy link
Contributor

✅ This change can build next-swc

Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
@turbo-orchestrator turbo-orchestrator bot removed area: docs Improvements or additions to documentation pkg: create-turbo Issues related to npx create-turbo labels May 10, 2024
Copy link
Contributor

github-actions bot commented May 10, 2024

🟢 CI successful 🟢

Thanks

@Zaid-maker
Copy link

Never the saw the CI that happy 😄

Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer to @chris-olszewski on this, but I'm ok with it!

Copy link
Contributor

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG official Rustacean @anthonyshew

@anthonyshew
Copy link
Contributor Author

@chris-olszewski If I knew all it took was changing a hardcoded string, I would have done it a long time ago.

If this makes me official, then #8157 makes me King Crab.

@anthonyshew anthonyshew merged commit 9d942e6 into turborepo_2 May 17, 2024
55 checks passed
@anthonyshew anthonyshew deleted the move-fs-cache-location branch May 17, 2024 01:45
chris-olszewski added a commit that referenced this pull request May 20, 2024
### Description

Moves the file system cache to `.turbo` as discussed in #842.

### Testing Instructions

Find your favorite Turborepo of choice and run a `turbo` command twice.
You should miss cache on the first run and hit cache on the second.

CLOSES TURBO-3130

---------

Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
chris-olszewski added a commit that referenced this pull request May 22, 2024
### Description

Moves the file system cache to `.turbo` as discussed in #842.

### Testing Instructions

Find your favorite Turborepo of choice and run a `turbo` command twice.
You should miss cache on the first run and hit cache on the second.

CLOSES TURBO-3130

---------

Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants