fix(Turborepo): Handle new packages in lockfile comparisons #8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
NicholasLYang
approved these changes
May 13, 2024
mehulkar
reviewed
May 13, 2024
Comment on lines
+12
to
+17
| Now build and verify that only the new package is in scope | ||
| Note that we need --skip-infer because we've now installed a local | ||
| turbo in this repo | ||
| Note that we need to disable path conversion because on windows, git bash considers | ||
| '//' to be an escape sequence translating to '/'. | ||
| $ MSYS_NO_PATHCONV=1 ${TURBO} --skip-infer build -F '[HEAD]' -F '!//' --dry=json | jq '.packages' |
There was a problem hiding this comment.
If this env var is just for the -F '!// flag on CLI, can you set it globally with this explanation?
It's very likely that this will come up again, especially as we do more work with root packages (e.g. tracing deps through root package.json)
There was a problem hiding this comment.
I tried it, and it appears we are relying on this behavior in other parts of our scripts. It might be possible to set it up properly, but I think that's beyond the scope of this particular PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When comparing lockfiles between revisions to identify what packages have been affected, we treated missing packages in the previous lockfile (added in the new lockfile) as errors, and fell back to considering all packages as affected. This change adds a boolean to determine what the behavior should be when we can't find a package that we expect. When building the package graph, it continues to be an error, as well as when tracing the dependencies of a package we've already found in the lockfile. However, for the first round of packages that we look for in a previous lockfile, we ignore missing packages. This allows us to more gracefully handle comparisons between commits that add new packages.
Testing Instructions
Added an integration test inspired by the repro from the linked issue.
Fixes #8125