[tests] Fix summary workflow to always run #10048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
styfle
changed the title
styfle
requested review from
TooTallNate,
EndangeredMassa,
cb1kenobi,
Ethan-Arrowood and
ijjk
as code owners
TooTallNate
previously approved these changes
May 31, 2023
TooTallNate
reviewed
May 31, 2023
.github/workflows/test.yml
Outdated
| steps: | ||
| - name: Done | ||
| run: echo "Done." | ||
| - run: |- |
There was a problem hiding this comment.
Should we add a name? Currently it shows as "Run for status in failure" or "Run for status in success"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures the Summary job always runs to check if any test failed and cause itself to fail as well.
This allows us to dynamically add as many concurrent jobs as we want but only have one (Summary) marked as required.
Testing
I verified this worked by making a change to
@vercel/static-configwhich is not required and the Summary check failed:https://github.com/vercel/vercel/actions/runs/5136560652/jobs/9243924596
Then I reverted it so that the test was passing and the Summary check passed:
https://github.com/vercel/vercel/actions/runs/5137401343/jobs/9245554297