[node] swap undici.fetch for undici.request in serverless-handler.mts
#10767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-Arrowood
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi,
trek and
Kikobeats
as code owners
🦋 Changeset detectedLatest commit: b7da26d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 24, 2023
Ethan-Arrowood
force-pushed
the
improve/serverless-function-dev-proxy
branch
from
7619a33
to
dfa22fe
Compare
Co-authored-by: Hugo Martinez <contact@hmartinez.fr>
Ethan-Arrowood
force-pushed
the
improve/serverless-function-dev-proxy
branch
from
dfa22fe
to
35ff6df
Compare
|
@Ethan-Arrowood I think that error in In fact, the Si I've made this PR : vercel/edge-runtime#672 |
…ss-function-dev-proxy
…ss-function-dev-proxy
…ss-function-dev-proxy
…ss-function-dev-proxy
|
Some tests were failing to do log incident yesterday. re-running now |
Ethan-Arrowood
added
the
pr: automerge
cb1kenobi
reviewed
Nov 8, 2023
EndangeredMassa
previously approved these changes
Nov 8, 2023
trek
previously approved these changes
Nov 8, 2023
Co-authored-by: Sean Massa <EndangeredMassa@gmail.com>
Ethan-Arrowood
dismissed stale reviews from trek and EndangeredMassa
via
b7da26d
EndangeredMassa
approved these changes
Nov 8, 2023
Merged
Ethan-Arrowood
pushed a commit
that referenced
this pull request
Nov 8, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@32.5.3 ### Patch Changes - Handle `TooManyProjects` error in places where projects are created ([#10807](#10807)) - Updated dependencies \[[`89c1e0323`](89c1e03), [`fd29b966d`](fd29b96)]: - @vercel/node@3.0.9 - @vercel/next@4.0.14 ## @vercel/next@4.0.14 ### Patch Changes - Fixed headers for static routes when PPR is enabled ([#10808](#10808)) ## @vercel/node@3.0.9 ### Patch Changes - Replace usage of `fetch` with `undici.request` ([#10767](#10767)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Kikobeats
added a commit
that referenced
this pull request
May 2, 2024
it's unnecessary after switched from node-fetch to undici: #10767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent undici update, setting the
hostheader for fetch requests became invalid (nodejs/undici#2322).We relied on this in order to proxy serverless dev server requests via
@vercel/node.This PR replaces the usage of
undici.fetchwithundici.request.It is blocked by an
undicitype change: nodejs/undici#2373