Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: ASGI support for newer python versions > 3.9 #11541

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bugfix: ASGI support for newer python versions > 3.9 #11541

wants to merge 2 commits into from
+14 −4

Conversation

winglian
Copy link

@winglian winglian commented May 4, 2024 •
edited

using any version of python > 3.9 results in <class 'TypeError'> when trying to launch an application like FastAPI

edit: closes #11545

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 4, 2024 •
edited

⚠️ No Changeset found

Latest commit: 1388afc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernests ernests mentioned this pull request May 6, 2024
Open
kytta
kytta suggested changes May 6, 2024
View reviewed changes
Copy link

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: I am not a maintainer

Quite a good solution, although I personally would do this differently. Either way, this would fix my issue (see #11545); it would be great, if you could mention it with the "closes" keyword :)

packages/python/vc_init.py Outdated Show resolved Hide resolved
@winglian winglian changed the title support newer python versions bugfix: ASGI support for newer python versions > 3.9 May 10, 2024
jeremyk
jeremyk reviewed May 10, 2024
View reviewed changes
packages/python/vc_init.py
return self.response

async def run_asgi(self, asgi_instance):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be run_asgi_instance as it appears line 215 is trying to call it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyk jeremyk jeremyk left review comments

@kytta kytta kytta requested changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@trek trek Awaiting requested review from trek trek is a code owner

@onsclom onsclom Awaiting requested review from onsclom onsclom is a code owner

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55 jeffsee55 is a code owner

@erikareads erikareads Awaiting requested review from erikareads erikareads is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python runtime does not work on Python 3.12 with ASGI
3 participants
@winglian @jeremyk @kytta