[now-next] Update 404 handling for pages/404 #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/zeit/now/av73b8qy5 |
ijjk
changed the title
timneutkens
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handling for treating
pages/404.jsas the custom error page in Next.js to allow for more flexible auto static optimization on the 404 page. This makes sure we handlepages/404.jsbeing a lambda due to_apphavinggetInitialPropsand also makes sure that visiting/404doesn't respond with a 200 status codeWe can add tests for this behavior after the below PR has been released in a canary of Next.jsx-ref: vercel/next.js#10329
x-ref: vercel/next.js#10593