[next] Add i18n support handling #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
previously approved these changes
Oct 17, 2020
styfle
reviewed
Oct 19, 2020
styfle
reviewed
Oct 19, 2020
styfle
reviewed
Oct 19, 2020
Co-authored-by: Steven <steven@ceriously.com>
…o ijjk/next/i18n-support
timneutkens
approved these changes
Oct 20, 2020
|
Merging this, as it'll be released on |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 20, 2020
This makes sure that we detect the correct default locale for domain specific locales since a domain can have a different default locale residing at the root and we need to check this on the client for prerendered/auto-static pages. This also makes sure we disable the built-in redirect handling when on Vercel since it's handled already. Tests for this are tricky since we need to load the browser with a custom domain which requires editing the host file. Existing tests should ensure this doesn't break non-domain specific locale behavior though. This was also tested manually while testing vercel/vercel#5298 x-ref: #17370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handling for the new i18n support in Next.js. Currently this relies on fixes in vercel/next.js#17926 for it to work properly and the
00-i18n-supportfixture should be updated to use canary after that PR is released.TODO:
x-ref: vercel/next.js#17370