Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-bridge] Ensure content-type is always set with multi-payloads #7681

Merged
merged 2 commits into from Apr 14, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 14, 2022

Related Issues

This ensures a content-type is always set inside of each part of the multi-part payload as it's needed for proper parsing. This also ensures non-200 status codes/headers are passed back separate when they differ so that they can be handled independently without assuming they all match.

x-ref: https://vercel.slack.com/archives/C03AYHB6MA9
x-ref: #7507

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #7681 (a008e18) into main (9225246) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7681   +/-   ##
=======================================
  Coverage   48.80%   48.80%           
=======================================
  Files         133      133           
  Lines        5331     5331           
  Branches     1338     1338           
=======================================
  Hits         2602     2602           
  Misses       2716     2716           
  Partials       13       13           

馃摚 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ijjk ijjk marked this pull request as ready for review April 14, 2022 21:00
@ijjk ijjk added the semver: patch PR contains bug fixes label Apr 14, 2022
@kodiakhq kodiakhq bot merged commit 46bf95e into main Apr 14, 2022
@kodiakhq kodiakhq bot deleted the ijjk/fix-multi-payload-missing-content-type branch April 14, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants