[next] Add caching for static font files #8620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanneslund
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi,
Ethan-Arrowood and
ijjk
as code owners
EndangeredMassa
changed the title
styfle
reviewed
Sep 23, 2022
There was a problem hiding this comment.
Seems correct but CI is failing.
I'm also wondering if we should put fonts into the existing media directory. Because we used to use /_next/static/images but then it was changed to /_next/static/media but I don't recall why.
Maybe @ijjk or @sokra knows the reason.
Update: I found this PR vercel/next.js#30168
|
I think that makes sense, closing this and changing the output path. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds caching for static font files emitted by
@next/font.