Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] read regions from middleware-manifest output #8629

Merged
merged 8 commits into from Sep 27, 2022
Merged

[next] read regions from middleware-manifest output #8629

merged 8 commits into from Sep 27, 2022

Conversation

Schniz
Copy link
Contributor

@Schniz Schniz commented Sep 25, 2022 •
edited

Related Issues

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@Schniz Schniz self-assigned this Sep 25, 2022
@Schniz Schniz requested a review from a team September 25, 2022 00:29
@Schniz Schniz added semver: minor PR contains new features area: next labels Sep 25, 2022
nuta
nuta reviewed Sep 26, 2022
View reviewed changes
packages/next/src/utils.ts Outdated Show resolved Hide resolved
styfle
styfle reviewed Sep 26, 2022
View reviewed changes
packages/next/src/utils.ts Outdated Show resolved Hide resolved
styfle
styfle reviewed Sep 26, 2022
View reviewed changes
packages/next/src/utils.ts Outdated Show resolved Hide resolved
styfle
styfle reviewed Sep 26, 2022
View reviewed changes
packages/next/src/utils.ts Outdated Show resolved Hide resolved
@Schniz @styfle
Update packages/next/src/utils.ts
9a93970 
Co-authored-by: Steven <steven@ceriously.com>
@styfle styfle added the pr: automerge Automatically merge the PR when checks pass label Sep 26, 2022
ijjk
ijjk requested changes Sep 27, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding for changes as discussed in https://vercel.slack.com/archives/C03S8ED1DKM/p1664188823380889

@styfle styfle removed the pr: automerge Automatically merge the PR when checks pass label Sep 27, 2022
@Schniz Schniz requested a review from ijjk September 27, 2022 12:58
@Schniz
Copy link
Contributor Author

Schniz commented Sep 27, 2022

@ijjk it's :done: can you please re-review 😁

@ijjk ijjk added the pr: automerge Automatically merge the PR when checks pass label Sep 27, 2022
@ijjk ijjk merged commit f674842 into main Sep 27, 2022
@ijjk ijjk deleted the schniz/ec-238-make-nextjs-builder-extract-preferred branch September 27, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuta nuta nuta left review comments

@styfle styfle styfle approved these changes

@ijjk ijjk ijjk approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@cb1kenobi cb1kenobi Awaiting requested review from cb1kenobi

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood Ethan-Arrowood is a code owner

Assignees

@Schniz Schniz

Labels
area: next pr: automerge Automatically merge the PR when checks pass semver: minor PR contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Schniz @styfle @nuta @ijjk