New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@vercel/edge] Support overriding request headers #8724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuta
force-pushed
the
edge-support-request-headers-manipulation
branch
from
October 13, 2022 06:35
ddca94d
to
889b0c7
Compare
Schniz
reviewed
Oct 19, 2022
Schniz
reviewed
Oct 19, 2022
Co-authored-by: Gal Schlezinger <gal@spitfire.co.il>
Co-authored-by: Gal Schlezinger <gal@spitfire.co.il>
4 tasks
Schniz
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
Implements request headers override in middlewares. #### New middleware headers - `x-middleware-override-headers`: A comma separated list of *all* request header names. Headers not listed will be deleted. - `x-middleware-request-<name>`: A new value for the header `<name>`. ### Related Issues - #8724: Add helper functions for non-Next.js middlewares - vercel/next.js#41380: Next.js' implementation ### 馃搵 Checklist <!-- Please keep your PR as a Draft until the checklist is complete --> #### Tests - [ ] The code changed/added as part of this PR has been covered with tests - [ ] All tests pass locally with `yarn test-unit` #### Code Review - [ ] This PR has a concise title and thorough description useful to a reviewer - [ ] Issue from task tracker has a link to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature in middleware to add, modify, or delete request headers. This feature is quite useful to pass data from middleware to Serverless/Edge API routes.
New APIs
Adds a new option
request.headers
to theMiddlewareResponseInit
parameter inNextResponse.next()
andNextResponse.rewrite()
. It's aHeader
object holding all request headers. Specifically:Example
New middleware headers
x-middleware-override-headers
: A comma separated list of all request header names. Headers not listed will be deleted.x-middleware-request-<name>
: A new value for the header<name>
.Related Issues
馃搵 Checklist
Tests
yarn test-unit
Code Review