Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

Conversation

priscilawebdev
Copy link
Contributor

Moves #51

import SvgIcon, { SvgIconProps } from '../../SvgIcon'

const License: React.FC<SvgIconProps> = props => (
<SvgIcon viewBox="0 0 490.652 490.652" {...props}>
Copy link
Member

@juanpicado juanpicado May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove original svg files is not good idea. Reasons:

  • This blow up the JS bundle

Master branch

  0.style.cdd1fdf79cd6bec30c42.css   1.91 KiB       0  [emitted]         vendors
     vendors.bb36852670bb2ecbf5d9.js    593 KiB       0  [emitted]  [big]  vendors
           1.bb36852670bb2ecbf5d9.js   20.7 KiB       1  [emitted]         
        main.bb36852670bb2ecbf5d9.js    123 KiB       2  [emitted]         main
           3.bb36852670bb2ecbf5d9.js   6.88 KiB       3  [emitted]         
           4.bb36852670bb2ecbf5d9.js    118 KiB       4  [emitted]         
           5.bb36852670bb2ecbf5d9.js   25.6 KiB       5  [emitted]         
    6.style.ad898c44026f788f7d59.css   11.1 KiB       6  [emitted]         
           6.bb36852670bb2ecbf5d9.js   31.1 KiB       6  [emitted]         
    manifest.bb36852670bb2ecbf5d9.js   3.25 KiB       7  [emitted]         manifest
                         favicon.ico   14.7 KiB          [emitted]         
                          index.html   1.29 KiB          [emitted]         

vs this branch

  0.style.cdd1fdf79cd6bec30c42.css   1.91 KiB       0  [emitted]         vendors
     vendors.46620792069afcb3c751.js    633 KiB       0  [emitted]  [big]  vendors
           1.46620792069afcb3c751.js   20.7 KiB       1  [emitted]         
        main.46620792069afcb3c751.js    146 KiB       2  [emitted]         main
           3.46620792069afcb3c751.js   6.96 KiB       3  [emitted]         
           4.46620792069afcb3c751.js    119 KiB       4  [emitted]         
           5.46620792069afcb3c751.js   21.5 KiB       5  [emitted]         
    6.style.ad898c44026f788f7d59.css   11.1 KiB       6  [emitted]         
           6.46620792069afcb3c751.js     31 KiB       6  [emitted]         
    manifest.46620792069afcb3c751.js   3.25 KiB       7  [emitted]         manifest
                         favicon.ico   14.7 KiB          [emitted]         
                          index.html   1.29 KiB          [emitted]         
  • It's hard to maintain if someone changes the formatting or modify something, it's really hard to see.
  • We need to lint files that aim never to be changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@material-ui/styles still alpha and unstable according to their docs.

https://material-ui.com/css-in-js/basics/
mui/material-ui#13663
https://github.com/mui-org/material-ui/milestones

@DanielRuf
Copy link
Contributor

Can this branch be deleted? Best is if we would use our personal forks with branches.

@priscilawebdev priscilawebdev deleted the refactor/51_replace_styled_components_by_makeStyles branch January 3, 2020 15:03
@juanpicado
Copy link
Member

@DanielRuf there is an issue with GitHub Actions and secrets, if you notice when using forks the CI fails, is due that, I think @sergiohgz has more context about it.

@DanielRuf
Copy link
Contributor

Was this an answer to my bot-token question somewhere? Not sure as I see no context here.

@priscilawebdev
Copy link
Contributor Author

@DanielRuf yes :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants