Skip to content

Commit

Permalink
fix: upgrade docker file base image to v20.12.1 (#4576)
Browse files Browse the repository at this point in the history
* fix: upgrade docker file base image to v20.12.1

* Update smok-test-module.yml

* Update .npmignore
  • Loading branch information
juanpicado committed Apr 6, 2024
1 parent 6868fdb commit 513b10d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/smok-test-module.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
- name: Use Node (latest)
- name: Use Node
uses: actions/setup-node@7c12f8017d5436eb855f1ed4399f037a36fbd9e8 # v2.5.2
with:
node-version-file: '.nvmrc'
node-version: 21
- name: Docker test
run: |
docker run -d -it --rm --name verdaccio -p 4873:4873 verdaccio/verdaccio:5
Expand All @@ -34,7 +34,7 @@ jobs:
run: |
source scripts/e2e-setup-ci.sh
npm init --force
npm install jest --registry http://localhost:4873
npm install jest@27.5.1 --registry http://localhost:4873
npm install verdaccio --registry http://localhost:4873
echo "test('require module should works', () => { const {runServer} = require('verdaccio') });" | tee module.spec.js
cat module.spec.js
Expand Down
1 change: 0 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ src/
/.*
.vscode/
.circleci/
debug/
docker-examples/
reports/
## assets and website
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=${BUILDPLATFORM:-linux/amd64} node:20.11.1-alpine as builder
FROM --platform=${BUILDPLATFORM:-linux/amd64} node:20.12.1-alpine as builder

ENV NODE_ENV=production \
VERDACCIO_BUILD_REGISTRY=https://registry.npmjs.org \
Expand Down Expand Up @@ -30,7 +30,7 @@ RUN yarn pack --out verdaccio.tgz \
## clean up and reduce bundle size
RUN rm -Rf /opt/verdaccio-build

FROM node:20.11.1-alpine
FROM node:20.12.1-alpine
LABEL maintainer="https://github.com/verdaccio/verdaccio"

ENV VERDACCIO_APPDIR=/opt/verdaccio \
Expand Down

0 comments on commit 513b10d

Please sign in to comment.