feat: replace request with @cypress/request (#4234)

* deps: request@2.88.2 -> @cypress/request@3.0.1

* yarn dedupe dependencies

* Fix comment

package.json

@@ -19,6 +19,7 @@
     "url": "https://opencollective.com/verdaccio"
   },
   "dependencies": {
+    "@cypress/request": "3.0.1",
     "@verdaccio/config": "7.0.0-next.4",
     "@verdaccio/core": "7.0.0-next.4",
     "@verdaccio/local-storage": "10.3.3",
@@ -52,7 +53,6 @@
     "mkdirp": "1.0.4",
     "mv": "2.1.1",
     "pkginfo": "0.4.1",
-    "request": "2.88.2",
     "semver": "7.5.4",
     "validator": "13.11.0",
     "verdaccio-audit": "12.0.0-next.4",

src/lib/notify/index.ts

@@ -1,6 +1,6 @@
+import { OptionsWithUrl } from '@cypress/request';
 import Handlebars from 'handlebars';
 import _ from 'lodash';
-import { OptionsWithUrl } from 'request';
 
 import { Config, Package, RemoteUser } from '@verdaccio/types';
 

src/lib/notify/notify-request.ts

@@ -1,6 +1,6 @@
+import request, { RequiredUriUrl } from '@cypress/request';
 import buildDebug from 'debug';
 import isNil from 'lodash/isNil';
-import request, { RequiredUriUrl } from 'request';
 
 import { HTTP_STATUS } from '../constants';
 import { logger } from '../logger';

src/lib/up-storage.ts

@@ -1,7 +1,7 @@
+import request from '@cypress/request';
 import JSONStream from 'JSONStream';
 import buildDebug from 'debug';
 import _ from 'lodash';
-import request from 'request';
 import Stream from 'stream';
 import URL, { UrlWithStringQuery } from 'url';
 import zlib from 'zlib';

test/lib/request.ts

@@ -1,6 +1,6 @@
+import request from '@cypress/request';
 import assert from 'assert';
 import _ from 'lodash';
-import request from 'request';
 
 import { IRequestPromise } from '../types';
 

test/unit/modules/basic_system.spec.ts

@@ -1,5 +1,5 @@
+import request from '@cypress/request';
 import express from 'express';
-import request from 'request';
 import rimraf from 'rimraf';
 
 import endPointAPI from '../../../src/api/index';

test/unit/modules/notifications/request.spec.ts

@@ -28,7 +28,7 @@ describe('Notifications:: notifyRequest', () => {
   });
 
   test('when notification service throws error', async () => {
-    jest.doMock('request', () => (options, resolver) => {
+    jest.doMock('@cypress/request', () => (options, resolver) => {
       const response = {
         statusCode: HTTP_STATUS.BAD_REQUEST,
       };
@@ -49,7 +49,7 @@ describe('Notifications:: notifyRequest', () => {
   });
 
   test('when notification service throws error with null error value', async () => {
-    jest.doMock('request', () => (options, resolver) => {
+    jest.doMock('@cypress/request', () => (options, resolver) => {
       const response = {
         statusCode: HTTP_STATUS.BAD_REQUEST,
         body: API_ERROR.BAD_DATA,
@@ -69,7 +69,7 @@ describe('Notifications:: notifyRequest', () => {
   });
 
   test('when notification is successfully delivered', async () => {
-    jest.doMock('request', () => (options, resolver) => {
+    jest.doMock('@cypress/request', () => (options, resolver) => {
       const response = {
         statusCode: HTTP_STATUS.OK,
         body: 'Successfully delivered',
@@ -90,7 +90,7 @@ describe('Notifications:: notifyRequest', () => {
   });
 
   test('when notification is successfully delivered but body is undefined/null', async () => {
-    jest.doMock('request', () => (options, resolver) => {
+    jest.doMock('@cypress/request', () => (options, resolver) => {
       const response = {
         statusCode: HTTP_STATUS.OK,
       };