Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement abbreviated manifest #3343

Merged
merged 3 commits into from Sep 3, 2022
Merged

feat: implement abbreviated manifest #3343

merged 3 commits into from Sep 3, 2022

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Sep 3, 2022

feat: implement abbreviated manifest

Enable abbreviated manifest data by adding the header:

curl -H "Accept: application/vnd.npm.install-v1+json" https://registry.npmjs.org/verdaccio

It returns a filtered manifest, additionally includes the time field by request.

Current support for packages managers:

  • npm: yes
  • pnpm: yes
  • yarn classic: yes
  • yarn modern (+2.x): no

https://github.com/npm/registry/blob/master/docs/responses/package-metadata.md#abbreviated-metadata-format

Follow up of #3322
Fixes for 5.x #2792

@verdacciobot verdacciobot marked this pull request as ready for review September 3, 2022 15:55
@juanpicado juanpicado merged commit 966139f into 5.x Sep 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the jota/feat-abbr1 branch September 3, 2022 15:55
@juanpicado
Copy link
Member Author

@zkochan I'm shipping this on v5.15.0 with the time field included.

@zkochan
Copy link
Collaborator

zkochan commented Sep 3, 2022

oh, that's great!

@zkochan
Copy link
Collaborator

zkochan commented Sep 3, 2022

@juanpicado looks like you do not pass all the needed fields in the abbreviated version. I just tried it in the pnpm e2e tests and some tests failed https://github.com/pnpm/pnpm/runs/8172441979?check_suite_focus=true

os, cpu, and peerDependenciesMeta should also be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants