Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid setting body for GET requests #3643

Merged
merged 4 commits into from Feb 24, 2023
Merged

fix: avoid setting body for GET requests #3643

merged 4 commits into from Feb 24, 2023

Commits on Feb 21, 2023

  1. fix: avoid setting body for GET requests 

    When making a GET request to certain uplinks, such as https://registry.npmmirror.com, setting the body field can result in a 413 error. Previously, the code was setting the body field for all requests, including GET requests.

This commit fixes the issue by checking the request method and avoiding setting the body field for GET requests. This ensures that GET requests are not affected by the issue and can be made without error.

Fixes verdaccio#3601
    @melodyVoid
    melodyVoid committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    07cdf46 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. add missing deps for run test locally

    @juanpicado @botao-tal
    juanpicado authored and botao-tal committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d3ce8a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. test(up-storage): add unit test about uplink is npmmirror 

    Cause thers is a bug in `isObject` function from `@verdaccio/core`, when `options.json` is `true`
GET request body will be string 'true', some uplinks might return 413 status code such as
https://registry.npmmirror.com

fix verdaccio#3601
    @botao-tal
    botao-tal committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    2395bd6 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. chore(deps): update @verdaccio/core

    @botao-tal
    botao-tal committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    f71f4b7 View commit details
    Browse the repository at this point in the history