New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix bug about isObject function #3647

Merged

juanpicado merged 2 commits into verdaccio:master from melodyVoid:master

Feb 23, 2023

Contributor

melodyVoid commented Feb 23, 2023

It should return false when input is a boolean

This bug will case
request has a body when options.json is true.


          fix(core): fix bug about isObject function, it should return false wh…

8bce011

…en input is a boolean

This bug will case
[request](https://github.com/verdaccio/verdaccio/blob/bae430fe24c9bb63dcf7b7b9e5f9f0dbf3f42669/src/lib/up-storage.ts#L157)
has a body when options.json is `true`.

fix verdaccio#3601

melodyVoid mentioned this pull request

fix: avoid setting body for GET requests #3643

Merged

juanpicado reviewed

View reviewed changes

Member

juanpicado left a comment

Please add a change set (check guidelines) so the package can be published


          docs(@verdaccio/core): add changeset

24f9a3f

juanpicado approved these changes

View reviewed changes

juanpicado merged commit 378e907 into verdaccio:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment