chore(types): Improve TS types for renderHTML and related functions #4605
Conversation
packages/core/url/src/index.ts
Outdated
| if (Array.isArray(forwardedProtocolHeaderValue)) { | ||
| // This really should never happen - only cookies are allowed to have | ||
| // multiple values. | ||
| throw new Error('invalid protocol header value'); |
There was a problem hiding this comment.
I'd consider this at least a bit bigger than a chore between minor and patch.
There was a problem hiding this comment.
You're right. It should have been patch I think
There was a problem hiding this comment.
Now I kind of want to split this PR up into two. First one where I just make this change, and then one where I improve the types. Do you want me to do that?
There was a problem hiding this comment.
I would recommend remove this part in order do not block the types part so I can give it some additional thoughts, because I remember this part might be an array, I barely remember
There was a problem hiding this comment.
I removed it. But have to type cast instead otherwise TS complains about the types (and rightfully so).
As soon as this is merged I'll open a new PR where I bring this back again. And I'll try to explain exactly how it changes behavior and in what scenarios.
Tobbe
changed the title
Tobbe
changed the title
Tobbe
changed the title
|
Followup PR here, as promised #4613 |
This PR adds more types to
renderHTML()and related functions to make it more type safe