Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add property forceMigrateToSecureLegacySignature #4625

Merged
merged 4 commits into from
May 5, 2024

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented May 5, 2024

  • reuse code from @verdaccio/auth and clean up duplicated code
  • follow up of feat: add migrateToSecureLegacySignature property #4621 implement forceMigrateToSecureLegacySignature and autoupgrade
  • breaking change for users that uses old secret token (64 characters length) and Node.js 22

Copy link

gitguardian bot commented May 5, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7921693 Triggered Generic High Entropy Secret 460e116 test/unit/partials/mock-store/.sinopia-db.json View secret
10612671 Triggered Generic High Entropy Secret 460e116 test/unit/partials/mock-store/.sinopia-db.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@juanpicado juanpicado mentioned this pull request May 5, 2024
@juanpicado juanpicado added this to the 5.x milestone May 5, 2024
@juanpicado juanpicado changed the title feat: migrate to forceMigrateToSecureLegacySignature feat: add property forceMigrateToSecureLegacySignature May 5, 2024
@juanpicado juanpicado marked this pull request as ready for review May 5, 2024 19:55
@juanpicado juanpicado merged commit 2941522 into 5.x May 5, 2024
37 checks passed
@delete-merged-branch delete-merged-branch bot deleted the node22-ci-option2 branch May 5, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant