Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix from 3.6.4 missing in 3.7 #84

Open
wants to merge 2 commits into
base: 3.7
Choose a base branch
from
Open

Bug fix from 3.6.4 missing in 3.7 #84

wants to merge 2 commits into from

Commits on Apr 29, 2019

  1. Bug Fix: Exception in hierarchical properties file 

    The hierarchical properties file processor thows a ArrayIndexOutOfBoundsException when file contains comments or blank lines.
The fix was to filter blank lines and lines starting with either "#" or "!" (after triming spaces) in the toJson method.

The patch was merged into 3.6.4 but I've been requested by Juilen to PR the patch into 3.7
    @Zru-B
    Zru-B committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    da2ee48 View commit details
    Browse the repository at this point in the history

  2. Update test file to include comments and blank lines 

    I've updated the hierarchical.properties to include comments (with both "#" and "!") and blank lines in order to test the bug fix for hierarchical processor throwing an exception when having properties file with comments and/or blank lines.
    @Zru-B
    Zru-B committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    f535a7d View commit details
    Browse the repository at this point in the history