Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2240 HTTP 400 error with vertx-web-openapi backend and Swagger UI #2241

Closed
wants to merge 1 commit into from

Conversation

bfreuden
Copy link
Contributor

Motivation:

According to a discussion in the OpenAPI specification github repo (discussion including Mike Ralphson, a major OpenAPI contributor), it seems that:

  1. */* is an acceptable value
  2. application/octet-stream is not equivalent to */*:

OAI/OpenAPI-Specification#1692 (comment)

But it is true that, when omitted in the spec, the application/octet-stream mime type is implied (and this precisely what Vert.x is doing):

https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.1.md#special-considerations-for-multipart-content

Supporting the */* content type will allow writing upload forms that will accept any type of file sent by Swagger UI.

@pk-work
Copy link
Contributor

pk-work commented May 31, 2024

I will close this PR because it looks abandoned and is related to a not longer maintained component.

In case I am wrong with my assessment, feel free to reopen the PR.

@pk-work pk-work closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants