Support AuthorizationHandlers on OpenAPI Operations #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to register an AuthorizationHandler on an Operation within the OpenAPI3RouterBuilder the resultant router will fail to build because the AuthZ handler is registered after the generated validation handler. Adding the ability to register AuthorizationHandlers on an Operation. All handlers added using the new authorizationHandler method will be registered after the security handlers but before the validation and user handlers.
This was referenced Oct 18, 2022
|
@pmlopes Any suggestions on how I can help move this forward? |
dwdunham
approved these changes
Mar 29, 2023
|
waiting for this feature |
|
Linked issues show it fixed in #2405 which is part of vertx 5.x I have not tested with vertx 5 yet. |
|
Hi, this is a PR related to a not longer maintained component. Do you know that there is a complete rebuild of Vert.x OpenAPI Router [1]? In Vert.x 5 this router has also support for AuthorizationHandlers [2]. Maybe this solves your problem. Is this PR still valid? If yes, please rebase this PR as there are conflicts. [1] https://vertx.io/docs/vertx-web-openapi-router/java/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to register an AuthorizationHandler on an Operation within the OpenAPI3RouterBuilder the resultant router will fail to build because the AuthZ handler is registered after the generated validation handler.
Adding the ability to register AuthorizationHandlers on an Operation. All handlers added using the new authorizationHandler method will be registered after the security handlers but before the validation and user handlers.
Motivation:
#2191
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines