Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add significance model generator cli #31098

Merged
merged 3 commits into from May 15, 2024
Merged

Conversation

MariusArhaug
Copy link
Contributor

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@MariusArhaug MariusArhaug changed the title Marius/add significance model tool Add significance model tool May 2, 2024
@MariusArhaug MariusArhaug marked this pull request as draft May 2, 2024 14:12
@MariusArhaug MariusArhaug force-pushed the marius/add-significance-model-tool branch 3 times, most recently from e442e67 to 1a2e92a Compare May 2, 2024 14:19
@MariusArhaug MariusArhaug force-pushed the marius/add-significance-model-tool branch 2 times, most recently from 4614ece to 4c33daf Compare May 14, 2024 14:18
@MariusArhaug MariusArhaug marked this pull request as ready for review May 14, 2024 14:18
@MariusArhaug MariusArhaug force-pushed the marius/add-significance-model-tool branch from 4c33daf to 8f337b9 Compare May 14, 2024 14:19
@MariusArhaug MariusArhaug force-pushed the marius/add-significance-model-tool branch from 8f337b9 to 74280df Compare May 14, 2024 14:23
@MariusArhaug MariusArhaug changed the title Add significance model tool Add significance model generator cli May 14, 2024
@MariusArhaug MariusArhaug requested a review from bjorncs May 14, 2024 14:24
@bjorncs
Copy link
Member

bjorncs commented May 15, 2024

[ERROR] Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 1.506 s <<< FAILURE! -- in com.yahoo.vespasignificance.SignificanceModelGeneratorTest
[ERROR] com.yahoo.vespasignificance.SignificanceModelGeneratorTest.testOverwriteExistingDocumentFrequencyLanguage -- Time elapsed: 0.069 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at com.yahoo.vespasignificance.SignificanceModelGeneratorTest.testOverwriteExistingDocumentFrequencyLanguage(SignificanceModelGeneratorTest.java:119)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[ERROR] com.yahoo.vespasignificance.SignificanceModelGeneratorTest.testGenerateSimpleFile -- Time elapsed: 0.014 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at com.yahoo.vespasignificance.SignificanceModelGeneratorTest.testGenerateSimpleFile(SignificanceModelGeneratorTest.java:60)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@MariusArhaug
Copy link
Contributor Author

Resolved testing error by using junit temp directory annotation

@bjorncs bjorncs merged commit f7e2c11 into master May 15, 2024
3 checks passed
@bjorncs bjorncs deleted the marius/add-significance-model-tool branch May 15, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants