Fix paths in types for nodenext
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
wooorm
approved these changes
Jun 9, 2022
wooorm
changed the title
nodenext
This comment has been minimized.
This comment has been minimized.
|
Thanks! I was working on the docs locally, which I’ll bundle with this. So expect a release this evening or tomorrow! |
|
Thanks! I'll hold off facebook/docusaurus#7586 till then. |
|
Thanks, released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
In TS 4.7, the new
moduleResolution: NodeNextmode would determine whether declaration files are ESM or CJS as well. If a declaration is thought to be ESM (e.g. because the package.json containstype: module), all imports must have .js extensions.We are already doing a great job and most import paths have .js extensions. The only offending one is
"..". This blocks the build without usingskipLibCheck, which causes facebook/docusaurus#7586 to fail. Docusaurus is not addingskipLibCheckfor our website because we have some hand-written declaration files, and in order to ensure their correctness we have to check them when compiling. This is the limitation of TS because TS does not allow excluding some declaration files while including others.