Integrate UPF feature and tests #883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ustiugov
reviewed
Nov 16, 2023
|
Hi @char-1ee I've already re-launched the runners, they should work fine now. But your codes still fail to pass these tests, please double check your codes and re-run the failed tests untill all of them are passed. |
char-1ee
force-pushed
the
firecracker-snapshot-upf
branch
3 times, most recently
from
23d83a1
to
03f0a07
Compare
char-1ee
force-pushed
the
firecracker-snapshot-upf
branch
from
f7a6985
to
c59492b
Compare
ustiugov
requested changes
Dec 11, 2023
| @@ -39,7 +39,7 @@ replace ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/firecracker-microvm/firecracker-containerd => github.com/vhive-serverless/firecracker-containerd v0.0.0-20230912063208-ad6383f05e45 | |||
| github.com/firecracker-microvm/firecracker-containerd => github.com/char-1ee/firecracker-containerd v0.0.0-20231018191519-49cac5eea134 | |||
There was a problem hiding this comment.
don't forget to update our fork after testing
char-1ee
force-pushed
the
firecracker-snapshot-upf
branch
4 times, most recently
from
67a757a
to
95e511d
Compare
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Signed-off-by: char-1ee <xingjianli59@gmail.com>
char-1ee
force-pushed
the
firecracker-snapshot-upf
branch
from
95e511d
to
5c2fff5
Compare
Signed-off-by: char-1ee <xingjian@gmail.com>
char-1ee
force-pushed
the
firecracker-snapshot-upf
branch
from
3f9c8eb
to
0ffd48d
Compare
Signed-off-by: char-1ee <xingjianli59@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate the firecracker snapshot UPF features and enable UPF tests.
Implementation Notes ⚒️
default-rootfs.imgExternal Dependencies 🍀
Breaking API Changes⚠️
Simply specify none (N/A) if not applicable.