Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-2469 Add framework/type to MLModelMetadata #502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

katiepeters
Copy link
Member

No description provided.

@github-actions github-actions bot added the safe to test committer is a member of this org label May 16, 2024
@katiepeters katiepeters marked this pull request as ready for review May 17, 2024 21:36
@tahiyasalam
Copy link
Member

Is there a corresponding app PR for this? We'll want to populate the model framework and model type information from the package metadata for ML Model, similar to how we do for the ML training scripts.

I also think we can revert this commit and instead use the ready-for-protos flag (more info here)

@katiepeters
Copy link
Member Author

@tahiyasalam there is not a corresponding app PR for this yet. Based on my limited understanding, it seemed like it made sense for this part to be done first? Or do they need to be done in tandem? Or..

@katiepeters katiepeters added the ready-for-protos add this when you want protos to compile on every commit label May 20, 2024
@tahiyasalam
Copy link
Member

@katiepeters I would expect there to be an app (and if applicable RDK) PR created in tandem. This will allow us to stage changes to ensure that introducing the new proto field work as intended and that there are no breaking app if the message is being used somewhere, which in this case it is since MLModelMetadata exists already. If there are any changes that need to be made to the proto field(s) that we discover while coordinating the changes across repos, the change is as easy as a commit instead of a potentially breaking change to api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org
Projects
None yet
2 participants