-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATA-2469 Add framework/type to MLModelMetadata #502
base: main
Are you sure you want to change the base?
Conversation
Is there a corresponding app PR for this? We'll want to populate the model framework and model type information from the package metadata for ML Model, similar to how we do for the ML training scripts. I also think we can revert this commit and instead use the |
@tahiyasalam there is not a corresponding app PR for this yet. Based on my limited understanding, it seemed like it made sense for this part to be done first? Or do they need to be done in tandem? Or.. |
@katiepeters I would expect there to be an app (and if applicable RDK) PR created in tandem. This will allow us to stage changes to ensure that introducing the new proto field work as intended and that there are no breaking app if the message is being used somewhere, which in this case it is since MLModelMetadata exists already. If there are any changes that need to be made to the proto field(s) that we discover while coordinating the changes across repos, the change is as easy as a commit instead of a potentially breaking change to api. |
No description provided.