Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA-2630 - Add time to MLTrainingVersion #503

Merged
merged 16 commits into from
May 22, 2024
Merged

DATA-2630 - Add time to MLTrainingVersion #503

merged 16 commits into from
May 22, 2024

Conversation

tahiyasalam
Copy link
Member

No description provided.

@github-actions github-actions bot added the safe to test committer is a member of this org label May 17, 2024
@tahiyasalam tahiyasalam added ready-for-protos add this when you want protos to compile on every commit and removed safe to test committer is a member of this org ready-for-protos add this when you want protos to compile on every commit labels May 17, 2024
@github-actions github-actions bot added the safe to test committer is a member of this org label May 17, 2024
@tahiyasalam
Revert "Merge branch 'add-time' of github.com:viamrobotics/api into a…
16bcd0d 
…dd-time"

This reverts commit c549e1e, reversing
changes made to f43d1a6.
@tahiyasalam tahiyasalam removed the ready-for-protos add this when you want protos to compile on every commit label May 20, 2024
@tahiyasalam tahiyasalam added the ready-for-protos add this when you want protos to compile on every commit label May 20, 2024
@tahiyasalam tahiyasalam changed the title Update version DATA-2630 - Add time to MLTrainingVersion May 20, 2024
@tahiyasalam tahiyasalam removed the ready-for-protos add this when you want protos to compile on every commit label May 20, 2024
@tahiyasalam tahiyasalam added ready-for-protos add this when you want protos to compile on every commit and removed protos-compiled ready-for-protos add this when you want protos to compile on every commit labels May 20, 2024
@tahiyasalam tahiyasalam added the ready-for-protos add this when you want protos to compile on every commit label May 20, 2024
@tahiyasalam tahiyasalam requested a review from agreenb May 20, 2024 18:50
@tahiyasalam tahiyasalam removed the ready-for-protos add this when you want protos to compile on every commit label May 22, 2024
@tahiyasalam
Copy link
Member Author

@Simberific this is technically a breaking change for the submit custom training job API, though it has not currently yet been released. The change can be summarized as: the registry versions associated with training scripts will now have more metadata returned (the time created). Would you mind merging when you get a chance?

@Simberific Simberific merged commit 3e4bcbc into main May 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agreenb agreenb agreenb approved these changes

Assignees
No one assigned
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
3 participants
@tahiyasalam @agreenb @Simberific