Add tag to the emitted JSON blob #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abe-winter
approved these changes
May 17, 2024
There was a problem hiding this comment.
lgtm
haven't looked at the receive side of this but I'm assuming an extra json field won't break anything
there is a toJSON function in the actions language if you want to give it a shot, which would in theory allow you to do something like:
client-payload: toJSON({repo_name: github.repository, sha: github.sha, tag: needs.bump-tag.outputs.new_tag})this is slightly safer in that it will do proper json escaping, but meh, your call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the tag version will allow the SDKs to pin to that specific release on buf.build