Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-2482: remove unnecessary ESLint and TypeScript rules #21

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

mcous
Copy link
Member

@mcous mcous commented Sep 11, 2023

Overview

Disable some rules that have been giving us grief:

ESLint

  • Turn off no-undef-init and unicorn/no-useless-undefined
  • In tests, turn off @typescript-eslint/no-unsafe-assignment and sonarjs/no-duplicate-string
  • In .svelte, turn off sonarjs/no-unused-collection because it crashes ESLint
  • When using arrow functions, disable no-confusing-void-expression so we're not forced to use a bunch of braces in event handlers

TypeScript

  • Turn off noPropertyAccessFromIndexSignature, because it's a purely stylistic concern, and it interacts poorly with with Svelte when components are accessed from Record objects
    • BREAKING CHANGE: this compiler option change will change linting behavior, which may cause previously passing code to start failing lint

Copy link
Member

@DTCurrie DTCurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcous mcous merged commit 0006127 into viamrobotics:main Sep 11, 2023
3 checks passed
@mcous mcous deleted the APP-2482_rule-disables branch September 11, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants