implement data task #208
Merged
implement data task #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvaradarajan
force-pushed
the
data_sync_task
branch
2 times, most recently
from
fe08f0d
to
e1a42b6
Compare
acmorrow
requested changes
May 20, 2024
micro-rdk/src/esp32/entry.rs
Outdated
| @@ -60,7 +61,7 @@ pub async fn serve_web_inner( | |||
| // instantiate the Async<TCPStream> for the connection to app.viam.com | |||
| // otherwise there is a chance a race happens and will listen to events before full | |||
| // initialization is done | |||
| let _ = Timer::after(std::time::Duration::from_millis(60)).await; | |||
| let _ = Box::pin(Timer::after(std::time::Duration::from_millis(60))).await; | |||
There was a problem hiding this comment.
- Can we add another block comment here explaining why this is
Box::pin. - I noticed that the native entry point does not have this wait. Should it? If not, why does it not need it but esp32 does? Is the comment still correct?
There was a problem hiding this comment.
- I forgot to take this out. I don't think it's necessary but I'll test to make sure
- I actually don't know, but the native server appears to work without it
| robot.clone(), | ||
| ); | ||
| } | ||
| let data_manager_svc = match DataManager::<StaticMemoryDataStore>::from_robot_and_config( |
There was a problem hiding this comment.
All relevant from esp32/entry.rs are re-iterated for this file.
gvaradarajan
force-pushed
the
data_sync_task
branch
from
1898cc8
to
7e810ee
Compare
gvaradarajan
force-pushed
the
data_sync_task
branch
from
7e810ee
to
fe805fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required an increase in main task stack size from 22528 -> 35840, which is not a reasonable increase, but I figured while I tried to diagnose the source of excess stack usage I would open a draft PR and see if anyone on the team has a better intuition for where the problem(s) might be.
EDIT: Pinning the future returned by
ViamServer::serveappears to have fixed it. Planning to do more testing before taking the PR out of draft.